This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Move cmd args to entry key #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in https://github.com/prettier/prettier/blob/master/.pre-commit-hooks.yaml#L3 This frees args keyword, so that it can be used downstream in pre-commit hooks Fixes prettier#16
joao-p-marques
force-pushed
the
fix-hooks-entry-definition
branch
from
dab6c4b
to
8ede582
Compare
|
This makes it not able to override |
|
Before we do any changes, Please read discussions with the author of |
|
Can't we override the |
yajo
approved these changes
Oct 21, 2020
|
Without this patch (and #18 or whatever works for it), to enable the XML plugin you need: - repo: https://github.com/prettier/pre-commit
rev: v2.1.2
hooks:
- id: prettier
name: prettier + plugin-xml
additional_dependencies:
- prettier@2.1.2
- "@prettier/plugin-xml@0.12.0"
args:
- --write
- --list-different
- --ignore-unknown
- --plugin=@prettier/plugin-xmlWhile before it was: - repo: https://github.com/prettier/prettier
rev: 2.1.2
hooks:
- id: prettier
name: prettier + plugin-xml
additional_dependencies:
- "@prettier/plugin-xml@0.12.0"
args:
- --plugin=@prettier/plugin-xmlClearly much better. Sadly that's broken since today (prettier/prettier#9459, still we don't know why). |
yajo
pushed a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Oct 23, 2020
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment. Once those are solved, we can start using the new repo.
yajo
pushed a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Oct 23, 2020
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment. Once those are solved, we can start using the new repo. Updated prettier BTW.
github-actions bot
pushed a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Oct 23, 2020
This seems to be a better fix (for now) than #149 because it just fixes the npm 7 installation problem without having to worry about prettier/pre-commit#17 or prettier/pre-commit#18 for the moment. Once those are solved, we can start using the new repo. Updated prettier BTW.
fisker
added a commit
that referenced
this pull request
Oct 27, 2020
joao-p-marques
added a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Nov 5, 2020
* Revert "Pin nodejs versions for pre-commit" This reverts commit 955f6dd. * Re-apply "Migrate prettier from prettier/prettier to prettier/pre-commit" This reverts commit 1f85193. * Improve prettier pre-commit configuration After prettier/pre-commit#17 was fixed
joao-p-marques
added a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Nov 5, 2020
* Revert "Pin nodejs versions for pre-commit" This reverts commit 955f6dd. * Re-apply "Migrate prettier from prettier/prettier to prettier/pre-commit" This reverts commit 1f85193. * Improve prettier pre-commit configuration After prettier/pre-commit#17 was fixed * Update to v2.1.2 in template config
joao-p-marques
added a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Nov 5, 2020
* Revert "Pin nodejs versions for pre-commit" This reverts commit 955f6dd. * Re-apply "Migrate prettier from prettier/prettier to prettier/pre-commit" This reverts commit 1f85193. * Improve prettier pre-commit configuration After prettier/pre-commit#17 was fixed * Update to v2.1.2 in template config
joao-p-marques
added a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Nov 5, 2020
* Revert "Pin nodejs versions for pre-commit" This reverts commit 955f6dd. * Re-apply "Migrate prettier from prettier/prettier to prettier/pre-commit" This reverts commit 1f85193. * Improve prettier pre-commit configuration After prettier/pre-commit#17 was fixed * Update to v2.1.2 in template config
yajo
added a commit
to Tecnativa/doodba-copier-template
that referenced
this pull request
Nov 5, 2020
* Migrate from prettier/prettier to prettier/pre-commit * Revert "Pin nodejs versions for pre-commit" This reverts commit 955f6dd. * Re-apply "Migrate prettier from prettier/prettier to prettier/pre-commit" This reverts commit 1f85193. * Improve prettier pre-commit configuration After prettier/pre-commit#17 was fixed * Update to v2.1.2 in template config * Update .pre-commit-config.yaml.jinja Co-authored-by: Jairo Llopis <Yajo@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in https://github.com/prettier/prettier/blob/master/.pre-commit-hooks.yaml#L3
This frees args keyword, so that it can be used downstream in pre-commit
hooks
Fixes #16