Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: develop less #281

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fix: develop less #281

merged 1 commit into from
Oct 21, 2021

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Oct 15, 2021

It seems that so many calls to develop slow down vscode. I'm not sure about it, but it looks a bit more snappy when this is removed.

Possibly, since the task changes the git repo and code workspace file, even when it remains the same, maybe those changes trigger some reloads that slow things down.

It's worth giving this a try IMHO.

@yajo yajo self-assigned this Oct 15, 2021
@yajo yajo added the bug Something isn't working label Oct 15, 2021
@yajo yajo modified the milestones: v3.1.0, v3.1.1 Oct 15, 2021
Copy link
Contributor

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, would we end up having to run the develop task manually more often? I am not against that, but maybe we should add something to the docs explaining it...

It seems that so many calls to develop slow down vscode. I'm not sure about it, but it looks a bit more snappy when this is removed.

Possibly, since the task changes the git repo and code workspace file, even when it remains the same, maybe those changes trigger some reloads that slow things down.

It's worth giving this a try IMHO.
@yajo
Copy link
Contributor Author

yajo commented Oct 21, 2021

Good idea, I added the docs.

@joao-p-marques joao-p-marques enabled auto-merge (rebase) October 21, 2021 08:49
@joao-p-marques joao-p-marques merged commit ffa92d1 into main Oct 21, 2021
@joao-p-marques joao-p-marques deleted the develop-less branch October 21, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants