Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oldArrayMerge() example code is non-executable #83

Closed
matatk opened this issue Oct 31, 2017 · 2 comments
Closed

oldArrayMerge() example code is non-executable #83

matatk opened this issue Oct 31, 2017 · 2 comments

Comments

@matatk
Copy link

matatk commented Oct 31, 2017

I'm trying to use the example oldArrayMerge() code given in the README but it won't run, as cloneIfNecessary() and isMergeableObject() are not defined. I see that isMergeableObject() can be got from another package (though it would be much neater if deepmerge could expose it as a pass-through), but cloneIfNecessary() doesn't seem to be defined anywhere.

My code depends on the pre-2.0.0 behaviour for array merging, so it would be really helpful to be able to reproduce this on the latest 2.0.0 code.

Thanks for this tool; it is very helpful, and I also appreciate the efforts you have gone to to explain how to keep the pre-2.0.0 behaviour; hope this issue report helps with that.

@TehShrike
Copy link
Owner

Good point. And relatedly, there's no example code executing that function - if there was, then jsmd would have caught the error when running the automated tests.

@matatk
Copy link
Author

matatk commented Nov 1, 2017

I did have a quick look at your build process, noticed jsmd and wondered what it did—sounds very helpful, and could be of use in a few projects on which I work; thanks :-).

matatk added a commit to matatk/landmarks that referenced this issue Nov 1, 2017
* Roll back to deepmerge 1.5.x due to change in behaviour
  TehShrike/deepmerge#83
* Add command definition for main-landmark.
* Add translation text for main-landmark.
* Simplify command handling in background script.
* Make error throwing consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants