Fix the oldArrayMerge example

[TehShrike]

Fixes #83

[TehShrike]

https://github.com/KyleAMathews/deepmerge/pull/84/files#diff-0730bb7c2e8f9ea2438b52e419dd86c9R146

jsmd will check this assertion to make sure the example actually works.

[TehShrike]

Look reasonable?

@matatk

[matatk]

Thanks for the really quick turnaround on this.

Have tried it and, I'm not sure why, but it's not producing the same results that 1.5.2 was for me. I'm currently unsure as to exactly what the root of the problem is, but one thing it's definitely doing is turning a string into an object of (letter index, letter) pairs.

e.g. [..., 'hello', ...] has become [..., {0: 'h', 1: 'e', 2: 'l', 3: 'l', 4: 'o'}, ...].

I was also wondering: given that deepmerge already uses is-mergeable-object, would it be possible for deepmerge to expose it so that I don't then need to add is-mergeable-object as an extra dependency?

[TehShrike]

mm, I'll bet that's due to clone defaulting to true now. If you pass in { clone: true } to 1.5.2, do you get the same string-spreading behavior?

[TehShrike]

ah nope, I mis-transcribed the clone function. It shouldn't try to clone if the input isn't a mergeable object.

[TehShrike]

I was also wondering: given that deepmerge already uses is-mergeable-object, would it be possible for deepmerge to expose it so that I don't then need to add is-mergeable-object as an extra dependency?

I made an issue #85 for that.

[matatk]

It's working fine now; thanks again, particularly for fixing this so quickly.

[TehShrike]

Published as 2.0.1