Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify messaging, remove calls to os.Exit and log.Fatal #42

Merged
merged 4 commits into from
Oct 23, 2021

Conversation

TekWizely
Copy link
Owner

@TekWizely TekWizely commented Oct 23, 2021

  • Allows built-in cmds to be called even if runfile not found
    • Prints not found ERROR messsage
  • Removes all os.Exit() calls
    • Modifies most code paths to pass exitCode up to main
    • Renames cmdExitCode => exitCode
  • Removes all log.Fatal() calls
    • Replaced with log.Print(); return 1
  • run with no args => custom message
    • Includes path to current runfile
    • Includes link to project homepage
  • In Shebang mode, run-version includes link to project homepage
  • run help => custom usage message
  • Suppresses warnings on fmt.* calls
    • either via //noinspection or via , = fmt.*
  • Simplifies messaging
    • Uses more lowercase messaging
    • Uses full uppercase for ERROR / WARNING
  • Improves failed assert messaging
  • Fixes bug: inverted nil check on os.Executable
  • Renames //noinspection => //goland:noinspection
  • Changes to appease the IntelliJ typo/grammar gods
  • Renames occurrences of RunFile => Runfile

@TekWizely TekWizely merged commit 27ff98d into master Oct 23, 2021
@TekWizely TekWizely deleted the no-exit branch October 23, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant