Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade elvishew to last version #14

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jmanriquehiberus
Copy link
Contributor

The purpose of the upgrade is to tackle the SW crash related to this jira ticket.

I found out we were using this library to log in smart wifi and the usage of elvishew so I searched for occurrences of the stack trace we had on the dependency's official repository.

There were many reports of this crash taking place in other apps, see:

The given solution by the dependency's developer was to upgrade to at least version 1.8.0 in order to fix this bug which is explained in further detail in the first issue of the list.

The solution was taken in this other PR.

Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

@DevPabloGarcia DevPabloGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jmanriquehiberus jmanriquehiberus merged commit bcd4273 into main Dec 13, 2023
1 check passed
@jmanriquehiberus jmanriquehiberus deleted the upgrade-elvishew-to-last-version branch December 13, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants