Add a second parameter to the termination callback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +23,7 @@ enableTerminate(server).listen(PORT)); | |||
|
|
|||
|
|
|||
| // When you want to stop your server... | |||
| server.terminate(function() { | |||
| server.terminate(function(err,terminatedByTimeout) { | |||
There was a problem hiding this comment.
Missing whitespace err, terminatedByTimeout
…en the server is not terminated by timeout
|
LGTM |
JoseAntonioRodriguez
pushed a commit
that referenced
this pull request
Sep 1, 2016
…has terminated by timeout (#1) * Add a second parameter to the callback indicating if the process finished by timeout * [[TEST]] Check that the new terminatedByTimeout parameter is false when the server is not terminated by timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a second parameter to the terminate callback to indicate if the server terminates by timeout