Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no SSL config + add HostAliases (for external Kafka) and NodePort for external Prometheus #38

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix: no SSL config + add HostAliases (for external Kafka) and NodePort for external Prometheus #38

merged 1 commit into from
Mar 31, 2020

Conversation

LoicLeGal
Copy link
Contributor

3 items here:

  • add ability to send metrics from an external Prometheus (nodeport in Helm chart)
  • add setting of remote kafka host (hostname resolution should be possible, use hostAliases of K8s)
  • Fix the NoSSL case when Kafka is not using ssl, data injection was not possible is ssl parameters given in the libkafka context (see main.go)

palmerabollo
palmerabollo reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@palmerabollo palmerabollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution. I've added some comments.

Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
helm/prometheus-kafka-adapter/templates/service.yaml Show resolved Hide resolved
helm/prometheus-kafka-adapter/values.yaml Outdated Show resolved Hide resolved
@LoicLeGal
Add HostAliases (for external Kafka); Add NodePort for external Prome…
3afd1f5 
…theus; Fix No SSL config

Fix for Pull-Request
Co-Authored-By: Guido García <guido.garciabernardo@telefonica.com>
@LoicLeGal LoicLeGal mentioned this pull request Mar 31, 2020
Closed
@palmerabollo palmerabollo changed the title Add HostAliases (for external Kafka); Add NodePort for external Prometheus; Fix No SSL config fix: no SSL config + add HostAliases (for external Kafka) and NodePort for external Prometheus Mar 31, 2020
@palmerabollo palmerabollo merged commit 0455720 into Telefonica:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palmerabollo palmerabollo palmerabollo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LoicLeGal @palmerabollo