Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: support sasl/scram authentication #46

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

mingqing
Copy link
Contributor

kafka client connect broker support SASL/SCRAM-* authentication, for example:

export KAFKA_BROKER_LIST="kafka1:9092,kafka2:9092,kafka3:9092"
export KAFKA_TOPIC="metrics"
export KAFKA_SECURITY_PROTOCOL="sasl_plaintext"
export KAFKA_SASL_MECHANISM="SCRAM-SHA-256"
export KAFKA_SASL_USERNAME="uptime"
export KAFKA_SASL_PASSWORD="testkey"

./prometheus-kafka-adapter

main.go Show resolved Hide resolved
Copy link
Member

@palmerabollo palmerabollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🎉 , looks good to me. Let's see if @jpfe-tid wants to add something else, otherwise I'll merge it and release a new version in a couple of days.

Copy link
Contributor

@jpfe-tid jpfe-tid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @mingqing ! 🚀

I've added some rewrite suggestions to avoid conflicts in config.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
@mingqing
Copy link
Contributor Author

Is it necessary to main.go "traefik/log" in is replaced by "logrus"? @jpfe-tid

@jpfe-tid
Copy link
Contributor

@mingqing thanks for noticing, we'll fix it by using only one logging package in the next PR (WIP), meantime we'll merge this PR.

@jpfe-tid jpfe-tid merged commit 91515c1 into Telefonica:master Jun 24, 2020
@jpfe-tid jpfe-tid added the enhancement New feature or request label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants