chore: bump some dependencies #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
palmerabollo
commented
Jun 26, 2020
palmerabollo
commented
- Remove github.com/containous/traefik/log (use logrus instead)
- Bump some mod versions (gin, etc). Upgrading librdkafka to 1.4.x and prometheus to 1.x is also recommended but it breaks current code, so it's not included in this PR.
- Include go test in the build process to avoid releasing versions that don't pass the unit tests by mistake.
jpfe-tid
approved these changes
Jun 26, 2020
| @@ -1,14 +1,15 @@ | |||
| FROM golang:1.14.1-alpine3.11 as build | |||
| FROM golang:1.14.4-alpine3.11 as build | |||
There was a problem hiding this comment.
Suggested change
| FROM golang:1.14.4-alpine3.11 as build | |
| FROM golang:1.14.4-alpine3.12 as build |
| RUN echo "@edge http://dl-cdn.alpinelinux.org/alpine/edge/main" >> /etc/apk/repositories && \ | ||
| echo "@edgecommunity http://dl-cdn.alpinelinux.org/alpine/edge/community" >> /etc/apk/repositories && \ | ||
| apk add --no-cache alpine-sdk 'librdkafka@edgecommunity>=1.3.0' 'librdkafka-dev@edgecommunity>=1.3.0' | ||
|
|
||
| WORKDIR /src/prometheus-kafka-adapter | ||
| ADD . /src/prometheus-kafka-adapter | ||
|
|
||
| RUN go test | ||
| RUN go build -o /prometheus-kafka-adapter | ||
|
|
||
| FROM alpine:3.11 |
There was a problem hiding this comment.
Suggested change
| FROM alpine:3.11 | |
| FROM alpine:3.12 |
| "github.com/gin-gonic/contrib/ginrus" | ||
| "github.com/gin-gonic/gin" | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/common/log" | ||
| "github.com/sirupsen/logrus" |
There was a problem hiding this comment.
Suggested change
| "github.com/sirupsen/logrus" | |
| log "github.com/sirupsen/logrus" |
| "github.com/gin-gonic/contrib/ginrus" | ||
| "github.com/gin-gonic/gin" | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/common/log" |
There was a problem hiding this comment.
Suggested change
| "github.com/prometheus/common/log" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.