Skip to content

Commit

Permalink
Fix: Don't destroy ad manager on detach (shaka-project#3665)
Browse files Browse the repository at this point in the history
  • Loading branch information
Álvaro Velad Galván committed Sep 28, 2021
1 parent 5969f6f commit 684dd85
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/player.js
Expand Up @@ -1321,9 +1321,8 @@ shaka.Player = class extends shaka.util.FakeEventTarget {
}

if (this.adManager_) {
// The ad manager is specific to the video, so dispose of it.
// The ad manager is specific to the video, so detach it too.
this.adManager_.release();
this.adManager_ = null;
}

// Clear our cached copy of the media element.
Expand Down

0 comments on commit 684dd85

Please sign in to comment.