Minor style fixes

toolium/driver_wrappers_pool.py

@@ -18,7 +18,6 @@
 
 import datetime
 import inspect
-import logging
 import os
 
 
@@ -123,8 +122,8 @@ def close_drivers_and_download_videos(cls, name, test_passed=True, maintain_defa
                 # Stop driver
                 driver_wrapper.driver.quit()
                 # Download video if necessary
-                if (driver_wrapper.config.getboolean_optional('Server', 'video_enabled')
-                    or not test_passed) and driver_wrapper.remote_node_video_enabled:
+                if (driver_wrapper.config.getboolean_optional('Server', 'video_enabled') or not test_passed) \
+                        and driver_wrapper.remote_node_video_enabled:
                     driver_wrapper.utils.download_remote_video(driver_wrapper.remote_node, driver_wrapper.session_id,
                                                                video_name.format(name, driver_index))
             except Exception:

toolium/test/pageelements/test_derived_page_element.py

@@ -77,6 +77,7 @@ def driver_wrapper():
 
     return driver_wrapper
 
+
 def test_locator(driver_wrapper):
     page_object = LoginPageObject(driver_wrapper)
 

toolium/test/pageobjects/examples/android/login.py

@@ -18,7 +18,7 @@
 
 from selenium.webdriver.common.by import By
 
-from toolium.pageelements import *
+from toolium.pageelements import InputText, Button
 from toolium.test.pageobjects.examples.base.login import BaseLoginPageObject
 
 

toolium/test/pageobjects/examples/ios/login.py

@@ -18,7 +18,7 @@
 
 from selenium.webdriver.common.by import By
 
-from toolium.pageelements import *
+from toolium.pageelements import InputText, Button
 from toolium.test.pageobjects.examples.base.login import BaseLoginPageObject
 
 

toolium/test/pageobjects/examples/login_one_file.py

@@ -18,7 +18,7 @@
 
 from selenium.webdriver.common.by import By
 
-from toolium.pageelements import *
+from toolium.pageelements import InputText, Button
 from toolium.pageobjects.mobile_page_object import MobilePageObject
 
 

toolium/test/test_config_driver.py

@@ -406,13 +406,13 @@ def test_create_remote_driver_capabilities(webdriver_mock, config):
 def test_convert_property_type_true(config):
     config_driver = ConfigDriver(config)
     value = 'True'
-    assert config_driver._convert_property_type(value) == True
+    assert config_driver._convert_property_type(value) is True
 
 
 def test_convert_property_type_false(config):
     config_driver = ConfigDriver(config)
     value = 'False'
-    assert config_driver._convert_property_type(value) == False
+    assert config_driver._convert_property_type(value) is False
 
 
 def test_convert_property_type_dict(config):

toolium/test/test_test_cases.py

@@ -65,7 +65,7 @@ def logger():
 
 def test_tear_down_pass(logger):
     test = run_mock('mock_pass')
-    assert test._test_passed == True
+    assert test._test_passed is True
 
     # Check logging messages
     init_message = 'Running new test: MockTestClass.mock_pass'
@@ -75,7 +75,7 @@ def test_tear_down_pass(logger):
 
 def test_tear_down_fail(logger):
     test = run_mock('mock_fail')
-    assert test._test_passed == False
+    assert test._test_passed is False
 
     # Check logging error messages
     init_message = 'Running new test: MockTestClass.mock_fail'

toolium/test/test_utils.py

@@ -172,7 +172,7 @@ def test_is_remote_video_enabled(utils):
         req_mock.get(url, json=config_response_json)
 
         # Get remote video configuration and check result
-        assert utils.is_remote_video_enabled('10.20.30.40') == True
+        assert utils.is_remote_video_enabled('10.20.30.40') is True
         assert url == req_mock.request_history[0].url
 
 
@@ -190,7 +190,7 @@ def test_is_remote_video_enabled_disabled(utils):
         req_mock.get(url, json=config_response_json)
 
         # Get remote video configuration and check result
-        assert utils.is_remote_video_enabled('10.20.30.40') == False
+        assert utils.is_remote_video_enabled('10.20.30.40') is False
         assert url == req_mock.request_history[0].url
 
 
@@ -200,7 +200,7 @@ def test_is_remote_video_enabled_non_grid_extras(req_get_mock, utils):
     req_get_mock.side_effect = ConnectionError('exception error')
 
     # Get remote video configuration and check result
-    assert utils.is_remote_video_enabled('10.20.30.40') == False
+    assert utils.is_remote_video_enabled('10.20.30.40') is False
 
 
 @pytest.mark.parametrize("driver_type, appium_app, appium_browser_name, bar_height", navigation_bar_tests)