Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix doc compilation errors in readthedocs #254

Merged
merged 1 commit into from Nov 10, 2021
Merged

fix: fix doc compilation errors in readthedocs #254

merged 1 commit into from Nov 10, 2021

Conversation

rgonalo
Copy link
Member

@rgonalo rgonalo commented Nov 10, 2021 •
edited

  • Upgrade Sphinx version from 3.* to 4.*
  • Move doc requirements to an specific file
  • Add readthedocs configuration in yaml file instead of using default conf
  • Update github actions and coverage links to master branch to unify README.rst links

URL to check that readthedocs now works with this PR: https://toolium.readthedocs.io/en/fix-readthedocs/changelog.html

@rgonalo rgonalo requested a review from a team November 10, 2021 11:46
@codeclimate
Copy link

codeclimate bot commented Nov 10, 2021

Code Climate has analyzed commit 2d59838 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.23% when pulling 2d59838 on fix/readthedocs into b5c3763 on master.

pabloge
pabloge approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@pabloge pabloge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgonalo rgonalo merged commit a96bae1 into master Nov 10, 2021
@rgonalo rgonalo deleted the fix/readthedocs branch November 10, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabloge pabloge pabloge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgonalo @coveralls @pabloge