Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add map param function and poeditor module #263

Merged
merged 14 commits into from
Feb 3, 2022

Conversation

pabloge
Copy link
Member

@pabloge pabloge commented Jan 21, 2022

Added the new function "map_param()" to the dataset module, to allow the replacement of some specific tags to configuration or environment values.

Also added the new module poeditor, to support the related logic in the above function.

toolium/utils/dataset.py Show resolved Hide resolved
toolium/utils/dataset.py Outdated Show resolved Hide resolved
toolium/utils/dataset.py Outdated Show resolved Hide resolved
toolium/utils/dataset.py Outdated Show resolved Hide resolved
toolium/utils/dataset.py Outdated Show resolved Hide resolved
toolium/utils/dataset.py Outdated Show resolved Hide resolved
toolium/utils/dataset.py Outdated Show resolved Hide resolved
toolium/utils/dataset.py Show resolved Hide resolved
toolium/utils/dataset.py Show resolved Hide resolved
toolium/utils/poeditor.py Show resolved Hide resolved
@pabloge pabloge requested a review from a team January 21, 2022 18:36
toolium/test/utils/test_dataset_map_param.py Outdated Show resolved Hide resolved
toolium/utils/poeditor.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 26, 2022

Coverage Status

Coverage decreased (-1.4%) to 88.958% when pulling 6a27190 on feat/add_map_param_function_and_poeditor_module into 2c08028 on master.

rgonalo
rgonalo previously approved these changes Jan 27, 2022
@codeclimate
Copy link

codeclimate bot commented Feb 3, 2022

Code Climate has analyzed commit 6a27190 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

View more on Code Climate.

@pabloge pabloge merged commit 80563ab into master Feb 3, 2022
@pabloge pabloge deleted the feat/add_map_param_function_and_poeditor_module branch February 3, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants