-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/add map param function and poeditor module #263
Merged
pabloge
merged 14 commits into
master
from
feat/add_map_param_function_and_poeditor_module
Feb 3, 2022
Merged
feat/add map param function and poeditor module #263
pabloge
merged 14 commits into
master
from
feat/add_map_param_function_and_poeditor_module
Feb 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgonalo
reviewed
Jan 26, 2022
rgonalo
reviewed
Jan 26, 2022
rgonalo
previously approved these changes
Jan 27, 2022
Code Climate has analyzed commit 6a27190 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
rgonalo
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new function "map_param()" to the dataset module, to allow the replacement of some specific tags to configuration or environment values.
Also added the new module poeditor, to support the related logic in the above function.