fix: ensure close_drivers method is always called in after feature hook #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgonalo
previously approved these changes
Feb 20, 2023
|
Code Climate has analyzed commit 08df6c1 and detected 0 issues on this pull request. View more on Code Climate. |
rgonalo
approved these changes
Feb 21, 2023
ZomeTlfca
added a commit
that referenced
this pull request
Mar 13, 2023
* fix: ensure close_drivers method is always called in after feature hook (#305) * fix: ensure close_drivers method is always called in after feature hook * add unit test and changelog entry * Release Toolium 2.7.0 (#306) * Initialize 2.7.1.dev0 version (#307) * update version and platform capabilities * fix redundant condition --------- Co-authored-by: Pablo Guijarro <pablo.guijarroenriquez@telefonica.com> Co-authored-by: Rubén González Alonso <ruben.gonzalezalonso@telefonica.com>
rgonalo
added a commit
that referenced
this pull request
Mar 17, 2023
* feat: upgrade to Selenium 4 and Appium 2 * update flake8 * skip visualtesting tests * disable DesiredCapabilities tests * feat: update visual testing methods to work with PIL (#308) * feat: update visual testing methods to work with PIL * fix lint errors * fix typo * fix: remove lettuce support (#309) * fix: add white background to diff images (#310) * fix: add white background to diff images * unify file path variables names * fix: update capabilities (#311) * fix: ensure close_drivers method is always called in after feature hook (#305) * fix: ensure close_drivers method is always called in after feature hook * add unit test and changelog entry * Release Toolium 2.7.0 (#306) * Initialize 2.7.1.dev0 version (#307) * update version and platform capabilities * fix redundant condition --------- Co-authored-by: Pablo Guijarro <pablo.guijarroenriquez@telefonica.com> Co-authored-by: Rubén González Alonso <ruben.gonzalezalonso@telefonica.com> * task: update executable path and remove opera and phantomjs (#304) * update executable path and remove opera and phantomjs * add change to safari * fix PR comments and update remote drivers * remove skip from test_config_driver * remove blank line * fix PR comments * add blank line * fix: refactor compare_files method to reduce complexity (#313) * add driver_wrapper.get_config_window_bounds tests and upgrade to alpha version * fix: gecko_driver_path is needed in local firefox executions (#314) * feat: add support for python 3.11 (#315) * feat: add support for python 3.11 * fix tests for unittest change for python 3.11 * fix too lengthy line * delete blank line * feat: make optional driver configuration and remove opera and phantomjs (#316) * fix: reduce complexity in unittest tearDown method (#317) * changed chrome --headless option to --headless=new (#318) --------- Co-authored-by: María Zomeño Gutiérrez <maria.zomenogutierrez@telefonica.com> Co-authored-by: Pablo Guijarro <pablo.guijarroenriquez@telefonica.com> Co-authored-by: María Hernández López <maria.hernandezlopez@telefonica.com> Co-authored-by: Rubén Ramos Pérez <e.everis10.tid@telefonica.com> Co-authored-by: Alain Miranda López <alain.mirandalopez@telefonica.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the close_drivers method in after_feature is always called. That was not happening when there had been a failure executing the preconditions, due to the exception that is raised in that case.