Fixes for Dependencies and Frameworks. #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating dependencies to use the new NPM cordova plugins Updating Google Play and Android Support libraries to use the frameworks tags.
This was referenced Jul 7, 2015
Don't need this. The Framework tag will handle it.
|
|
||
| <!-- android --> | ||
| <platform name="android"> | ||
|
|
||
| <dependency id="com.google.playservices" url="https://github.com/MobileChromeApps/google-play-services.git"/> | ||
| <framework src="com.google.android.gms:play-services:7.5.0" /> |
There was a problem hiding this comment.
What you really need to import is gcm, like this: https://github.com/jeduan/cordova-plugin-push-notification/blob/master/plugin.xml#L65
|
I have added this, but still have the same problem. Anything else I need to do? phonegap build android still gives me the same errors |
|
I also added this but still having the same errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependencies to use the new NPM cordova plugins
Updating Google Play and Android Support libraries to use the frameworks tags.