[Improvement] Only initialize the heartbeat thread pool when the role is driver #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spark2 also have similar problems. Could you modify the spark2 at the same time? |
|
Updated @jerqi . I'm confused that when heartbeat failed, it will do nothing. Right? |
Heartbeat is to notify shuffle server app is alive, and every rpc also will do the notify. According to current implementation, ignore the failed rpc. |
|
If shuffle server hasn't received any heartbeat of application, shuffle server will delete the shuffle data of the application. |
jerqi
changed the title
jerqi
approved these changes
Jun 16, 2022
This was referenced Jun 22, 2022
jerqi
added a commit
that referenced
this pull request
Jun 22, 2022
backport 0.5.0 ### What changes were proposed in this pull request? We need to judge heartbeatExecutorService whether is null when we will stop it. ### Why are the changes needed? #177 pr introduce this problem, when we run Spark applications on our cluster, the executor will throw NPE when method `stop` is called. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual test
jerqi
added a commit
that referenced
this pull request
Jun 22, 2022
### What changes were proposed in this pull request? We need to judge heartbeatExecutorService whether is null when we will stop it. ### Why are the changes needed? #177 pr introduce this problem, when we run Spark applications on our cluster, the executor will throw NPE when method `stop` is called. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual test
jerqi
added a commit
that referenced
this pull request
Jun 22, 2022
backport 0.5.0 ### What changes were proposed in this pull request? We need to judge heartbeatExecutorService whether is null when we will stop it. ### Why are the changes needed? #177 pr introduce this problem, when we run Spark applications on our cluster, the executor will throw NPE when method `stop` is called. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Only initialize the heartbeat thread pool when the role is driver
Why are the changes needed?
Just to avoid creating extra thread pool.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No