Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] [0.5.0] Fix spark2 executor stop NPE problem #187

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jerqi
Copy link
Collaborator

@jerqi jerqi commented Jun 22, 2022

backport 0.5.0

What changes were proposed in this pull request?

We need to judge heartbeatExecutorService whether is null when we will stop it.

Why are the changes needed?

#177 pr introduce this problem, when we run Spark applications on our cluster, the executor will throw NPE when method stop is called.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manual test

@jerqi jerqi changed the title [Bugfix] [0.5.0]Fix spark2 executor stop NPE problem [Bugfix] [0.5.0] Fix spark2 executor stop NPE problem Jun 22, 2022
Copy link
Collaborator

@colinmjj colinmjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi
Copy link
Collaborator Author

jerqi commented Jun 22, 2022

Later we will add Yarn MiniCluster UT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants