fix(ios): update visibility available now

Tencent · Sep 10, 2021 · 988106c · 988106c
1 parent d28f693
commit 988106c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/ios/sdk/component/view/HippyShadowView.h b/ios/sdk/component/view/HippyShadowView.h
@@ -70,6 +70,7 @@ typedef void (^HippyApplierVirtualBlock)(NSDictionary<NSNumber *, HippyVirtualNo
 @property (nonatomic, weak) HippyBridge *bridge;
 @property (nonatomic, assign) MTTDirection layoutDirection;
 @property (nonatomic, copy) NSString *visibility;
+@property (nonatomic, assign) BOOL visibilityChanged;
 
 /**
  * isNewView - Used to track the first time the view is introduced into the hierarchy.  It is initialized YES, then is

diff --git a/ios/sdk/component/view/HippyShadowView.mm b/ios/sdk/component/view/HippyShadowView.mm
@@ -147,7 +147,7 @@ @implementation HippyShadowView {
 - (void)applyLayoutNode:(MTTNodeRef)node
       viewsWithNewFrame:(NSMutableSet<HippyShadowView *> *)viewsWithNewFrame
        absolutePosition:(CGPoint)absolutePosition {
-    if (!MTTNodeHasNewLayout(node)) {
+    if (!MTTNodeHasNewLayout(node) && !_visibilityChanged) {
         return;
     }
     MTTNodesetHasNewLayout(node, false);
@@ -170,9 +170,11 @@ - (void)applyLayoutNode:(MTTNodeRef)node
                      },
         { HippyRoundPixelValue(absoluteBottomRight.x - absoluteTopLeft.x), HippyRoundPixelValue(absoluteBottomRight.y - absoluteTopLeft.y) } };
 
-    if (!CGRectEqualToRect(frame, _frame)) {
+    if (!CGRectEqualToRect(frame, _frame) ||
+        _visibilityChanged) {
         _frame = frame;
         [viewsWithNewFrame addObject:self];
+        _visibilityChanged = NO;
     }
 
     absolutePosition.x += MTTNodeLayoutGetLeft(node);
@@ -414,6 +416,14 @@ - (BOOL)isHidden {
     return _hidden || [_visibility isEqualToString:@"hidden"];
 }
 
+- (void)setVisibility:(NSString *)visibility {
+    if (![_visibility isEqualToString:visibility]) {
+        _visibility = visibility;
+        _visibilityChanged = YES;
+        MTTNodeMarkDirty(self.nodeRef);
+    }
+}
+
 - (void)insertHippySubview:(HippyShadowView *)subview atIndex:(NSInteger)atIndex {
     [_hippySubviews insertObject:subview atIndex:atIndex];
     if (![self isCSSLeafNode]) {