feat(core): add willexit callback

Tencent · Mar 16, 2023 · bd64345 · bd64345
1 parent 2ea7581
commit bd64345
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/core/include/core/scope.h b/core/include/core/scope.h
@@ -119,6 +119,10 @@ class Scope {
     turbo_host_object_map_[name] = host_object;
   }
 
+  inline void AddWillExitCallback(std::function<void()> cb) { // cb will run in the js thread
+    will_exit_cbs_.push_back(cb);
+  }
+
  private:
   friend class Engine;
   void Init();
@@ -140,4 +144,5 @@ class Scope {
   std::vector<std::unique_ptr<hippy::napi::FuncWrapper>> func_wrapper_holder_;
   std::unordered_map<std::string, std::shared_ptr<CtxValue>> turbo_instance_map_;
   std::unordered_map<std::string, std::any> turbo_host_object_map_;
+  std::vector<std::function<void()>> will_exit_cbs_;
 };
diff --git a/core/src/scope.cc b/core/src/scope.cc
@@ -86,10 +86,10 @@ Scope::~Scope() {
 void Scope::WillExit() {
   TDF_BASE_DLOG(INFO) << "WillExit begin";
   std::promise<std::shared_ptr<CtxValue>> promise;
-  std::future<std::shared_ptr<CtxValue>> future = promise.get_future();
+  auto future = promise.get_future();
   std::weak_ptr<Ctx> weak_context = context_;
-  JavaScriptTask::Function cb = hippy::base::MakeCopyable(
-      [weak_context, p = std::move(promise)]() mutable {
+  auto cb = hippy::base::MakeCopyable(
+      [weak_context, will_exit_cbs = will_exit_cbs_, p = std::move(promise)]() mutable {
         TDF_BASE_LOG(INFO) << "run js WillExit begin";
         std::shared_ptr<CtxValue> rst = nullptr;
         auto context = weak_context.lock();
@@ -102,6 +102,9 @@ void Scope::WillExit() {
             context->CallFunction(fn, 0, nullptr);
           }
         }
+        for (const auto& will_exit_cb: will_exit_cbs) {
+          will_exit_cb();
+        }
         p.set_value(rst);
       });
   auto runner = GetTaskRunner();