feat(core): change memcpy to std::copy_n

Tencent · Mar 16, 2023 · e4174dd · e4174dd
1 parent 9acbf5c
commit e4174dd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/core/src/vm/v8/snapshot_deserializer.cc b/core/src/vm/v8/snapshot_deserializer.cc
@@ -22,6 +22,8 @@
 
 #include "core/vm/v8/snapshot_deserializer.h"
 
+#include <algorithm>
+
 #include "core/base/common.h"
 
 SnapshotDeserializer::SnapshotDeserializer(const std::vector<uint8_t>& buffer)
@@ -35,7 +37,7 @@ bool SnapshotDeserializer::ReadUInt32(uint32_t& value) {
     error_message_ = GetErrorMessage("uint32", sizeof(value), length_ - position_);
     return false;
   }
-  memcpy(&value, buffer_ + position_, sizeof(value));
+  std::copy_n(buffer_ + position_, sizeof(value), reinterpret_cast<uint8_t*>(&value));
   position_ += sizeof(value);
   error_message_.clear();
   return true;
@@ -61,7 +63,7 @@ bool SnapshotDeserializer::ReadBuffer(void* p, size_t length) {
     error_message_ = GetErrorMessage("buffer", length, length_ - position_);
     return false;
   }
-  memcpy(p, buffer_ + position_, length);
+  std::copy_n(buffer_ + position_, length, reinterpret_cast<uint8_t*>(p));
   position_ += length;
   error_message_.clear();
   return true;

diff --git a/core/src/vm/v8/snapshot_serializer.cc b/core/src/vm/v8/snapshot_serializer.cc
@@ -22,6 +22,8 @@
 
 #include "core/vm/v8/snapshot_serializer.h"
 
+#include <algorithm>
+
 #include "core/base/common.h"
 
 void SnapshotSerializer::WriteUInt32(uint32_t value) {
@@ -38,6 +40,7 @@ void SnapshotSerializer::WriteBuffer(const void* p, size_t length) {
   if (buffer_.capacity() <= buffer_.size() + length) {
     buffer_.resize(buffer_.size() + length);
   }
-  memcpy(&buffer_[0] + position_, p, length);
+
+  std::copy_n(reinterpret_cast<const uint8_t*>(p), length, &buffer_[0] + position_);
   position_ += length;
 }