Skip to content

Commit

Permalink
fix(ios): improve stability
Browse files Browse the repository at this point in the history
  • Loading branch information
ozonelmy authored and zoomchan-cxj committed Nov 16, 2021
1 parent 72c0879 commit ec2686f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 4 additions & 4 deletions ios/sdk/base/HippyBatchedBridge.mm
Expand Up @@ -1047,12 +1047,12 @@ - (id)callNativeModule:(NSUInteger)moduleID method:(NSUInteger)methodID params:(
// if (!_valid) {
// return nil;
// }

if (moduleID >= [_moduleDataByID count]) {
HippyLogError(@"moduleID %lu exceed range of _moduleDataByID %lu, bridge is valid %ld", moduleID, [_moduleDataByID count], (long)_valid);
NSArray<HippyModuleData *> *moduleDataByID = [_moduleDataByID copy];
if (moduleID >= [moduleDataByID count]) {
HippyLogError(@"moduleID %lu exceed range of moduleDataByID %lu, bridge is valid %ld", moduleID, [moduleDataByID count], (long)_valid);
return nil;
}
HippyModuleData *moduleData = _moduleDataByID[moduleID];
HippyModuleData *moduleData = moduleDataByID[moduleID];
if (HIPPY_DEBUG && !moduleData) {
HippyLogError(@"No module found for id '%lu'", (unsigned long)moduleID);
return nil;
Expand Down
4 changes: 3 additions & 1 deletion ios/sdk/base/HippyTouchHandler.m
Expand Up @@ -355,7 +355,9 @@ - (BOOL)checkViewBelongToTouchHandler:(UIView *)view {
if (!checkView) {
NSNumber *viewRootTag = [view rootTag];
NSNumber *rootViewTag = [_rootView hippyTag];
return [viewRootTag isEqualToNumber:rootViewTag];
if (rootViewTag) {
return [viewRootTag isEqualToNumber:rootViewTag];
}
}
return checkView == view;
}
Expand Down

0 comments on commit ec2686f

Please sign in to comment.