fix(core.gradle-plugin): 支持从低版本AGP中获取Manifest

fixup! 8a99c4f fix #747
Tencent · Jan 5, 2022 · b040630 · b040630
1 parent 520aa3f
commit b040630
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 14 deletions.
diff --git a/...cts/sdk/core/gradle-plugin/src/main/kotlin/com/tencent/shadow/core/gradle/ShadowPlugin.kt b/...cts/sdk/core/gradle-plugin/src/main/kotlin/com/tencent/shadow/core/gradle/ShadowPlugin.kt
@@ -18,9 +18,12 @@
 
 package com.tencent.shadow.core.gradle
 
+import com.android.SdkConstants.ANDROID_MANIFEST_XML
 import com.android.build.gradle.AppExtension
 import com.android.build.gradle.AppPlugin
 import com.android.build.gradle.BaseExtension
+import com.android.build.gradle.tasks.ManifestProcessorTask
+import com.android.build.gradle.tasks.ProcessApplicationManifest
 import com.android.build.gradle.tasks.ProcessMultiApkApplicationManifest
 import com.tencent.shadow.core.gradle.extensions.PackagePluginExtension
 import com.tencent.shadow.core.manifest_parser.generatePluginManifest
@@ -99,7 +102,7 @@ class ShadowPlugin : Plugin<Project> {
         }.forEach { pluginVariant ->
             val output = pluginVariant.outputs.first()
             val processManifestTask = output.processManifestProvider.get()
-            val manifestFile = (processManifestTask as ProcessMultiApkApplicationManifest).mainMergedManifest.get().asFile
+            val manifestFile = getManifestFile(processManifestTask)
             val variantName = manifestFile.parentFile.name
             val outputDir = File(project.buildDir, "generated/source/pluginManifest/$variantName")
 
@@ -108,20 +111,22 @@ class ShadowPlugin : Plugin<Project> {
                 it.dependsOn(processManifestTask)
                 it.inputs.file(manifestFile)
                 it.outputs.dir(outputDir).withPropertyName("outputDir")
-                val packageForR = (project.tasks.getByName("processPluginDebugResources").property("namespace") as Property<String>).get()
+
+                val packageForR = getPackageForR(project, variantName)
+
                 it.doLast {
-                    generatePluginManifest(manifestFile,
-                            outputDir,
-                            "com.tencent.shadow.core.manifest_parser",
-                            packageForR)
+                    generatePluginManifest(
+                        manifestFile,
+                        outputDir,
+                        "com.tencent.shadow.core.manifest_parser",
+                        packageForR
+                    )
                 }
             }
             project.tasks.getByName("compile${variantName.capitalize()}JavaWithJavac").dependsOn(task)
 
             // 把PluginManifest.java添加为源码
-            appExtension.sourceSets.getByName(variantName).java {
-                srcDir(outputDir)
-            }
+            appExtension.sourceSets.getByName(variantName).java.srcDir(outputDir)
         }
     }
 
@@ -176,4 +181,40 @@ class ShadowPlugin : Plugin<Project> {
         }
     }
 
+    companion object {
+        private fun getManifestFile(processManifestTask: ManifestProcessorTask) =
+            when (processManifestTask) {
+                is ProcessMultiApkApplicationManifest -> {
+                    processManifestTask.mainMergedManifest.get().asFile
+                }
+                is ProcessApplicationManifest -> {
+                    try {
+                        processManifestTask.mergedManifest.get().asFile
+                    } catch (e: NoSuchMethodError) {
+                        //AGP小于4.1.0
+                        val dir =
+                            processManifestTask.outputs.files.files
+                                .first { it.path.contains("merged_manifests") }
+                        File(dir, ANDROID_MANIFEST_XML)
+                    }
+                }
+                else -> throw IllegalStateException("不支持的Task类型:${processManifestTask.javaClass}")
+            }
+
+        private fun getPackageForR(project: Project, variantName: String): String {
+            val linkApplicationAndroidResourcesTask =
+                project.tasks.getByName("process${variantName.capitalize()}Resources")
+            return (when {
+
+                linkApplicationAndroidResourcesTask.hasProperty("namespace") -> {
+                    linkApplicationAndroidResourcesTask.property("namespace")
+                }
+                linkApplicationAndroidResourcesTask.hasProperty("originalApplicationId") -> {
+                    linkApplicationAndroidResourcesTask.property("originalApplicationId")
+                }
+                else -> throw IllegalStateException("不支持的AGP版本")
+            } as Property<String>).get()
+        }
+    }
+
 }
diff --git a/projects/sdk/core/manifest-parser/build.gradle b/projects/sdk/core/manifest-parser/build.gradle
@@ -12,6 +12,7 @@ dependencies {
 compileKotlin {
     kotlinOptions {
         jvmTarget = "1.6"
+        apiVersion = "1.3"// 兼容低版本Gradle和https://youtrack.jetbrains.com/issue/KT-39389
     }
 }
 

diff --git a/...parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGenerator.kt b/...parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGenerator.kt
@@ -352,10 +352,5 @@ private class PluginManifestBuilder(
                         else -> throw IllegalArgumentException("不认识$it")
                     }
                 }
-
-        private fun String.capitalize() =
-                replaceFirstChar {
-                    if (it.isLowerCase()) it.titlecase(Locale.getDefault()) else it.toString()
-                }
     }
 }