Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sun.misc.BASE64Encoder with java.util.Base64 #69

Closed
tisonkun opened this issue Oct 9, 2019 · 6 comments
Closed

Replace sun.misc.BASE64Encoder with java.util.Base64 #69

tisonkun opened this issue Oct 9, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Oct 9, 2019

Currently, we use internal class sun.misc.BASE64Encoder inside com.tencent.tubemq.server.broker.BrokerServiceServer. This class cannot be accessed anymore since Java 11. Although we might not have a upgrade plan in the near future, we can safely do the replacement following the existing solution in JDK community.

@tisonkun tisonkun added the enhancement New feature or request label Oct 9, 2019
@tisonkun tisonkun self-assigned this Oct 9, 2019
tisonkun added a commit to tisonkun/TubeMQ that referenced this issue Oct 9, 2019
tisonkun added a commit to tisonkun/TubeMQ that referenced this issue Oct 9, 2019
@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 9, 2019

defer until we have a plan to upgrade to Java 11

please do not close this issue since it is valid anyway.

@gosonzhang
Copy link
Collaborator

It is better to make the base64 encoding into a utils class.

@tisonkun
Copy link
Contributor Author

@gosonzhang do you mean we implement a TubeMQ scope Base64 encoder?

@gosonzhang
Copy link
Collaborator

see #91

guangxuCheng pushed a commit to guangxuCheng/TubeMQ that referenced this issue Jul 3, 2020
…s changed (Tencent#69)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
@ZoranNik91
Copy link

I have the same error in the build: sun/misc/BASE64Encoder.
So you guys recommended replacing java.util.Base64.
How do I do this in Eclipse, just adding a jar file library in the build path of the project, or is there more job to do?
I'm new to Eclipse...

@gosonzhang
Copy link
Collaborator

gosonzhang commented Nov 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants