Add logxxx to log comp xxx rewriter where xxx = sigmoid or softmax #4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this is not a templated implementation; it rewrites logsigmoid/logsoftmax nodes only and will not adapt to additions of operators in the future. |
lrw04
changed the title
|
I prefer this over making softmax/sigmoid layers also act as logsoftmax/logsigmoid layers since that would be unnatural. |
|
please add test for the nn.module style ones |
|
I believe they were already added in the earliest commit, at |
|
Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds passes to pnnx's pass_ncnn that rewrites logsigmoid/logsoftmax nodes into compositions of log nodes and sigmoid/softmax nodes.