-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gelu vulkan operator #5001
add gelu vulkan operator #5001
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5001 +/- ##
=======================================
Coverage 94.71% 94.72%
=======================================
Files 767 768 +1
Lines 228515 228610 +95
=======================================
+ Hits 216445 216540 +95
Misses 12070 12070
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: nihui <shuizhuyuanluo@126.com>
Thanks for your contribution ! |
for MacOS with vulkan fp16 build failed. |
more details on this?😮 |
tanh fp16 on moltenvk has precision issue, so it is banned on half values workaround follows (ref tanh comp)
|
so it shuold look like this?
|
yeah, exactly |
add gelu vulkan operator