Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setjmp()/longjmp() #22

Closed
miloyip opened this issue Jun 26, 2014 · 1 comment · Fixed by #25
Closed

Remove setjmp()/longjmp() #22

miloyip opened this issue Jun 26, 2014 · 1 comment · Fixed by #25

Comments

@miloyip
Copy link
Collaborator

miloyip commented Jun 26, 2014

https://code.google.com/p/rapidjson/issues/detail?id=79
As reported by Anton.Breusov, there are potential issues with setjmp()/longjmp().
Try removing them and evaluate the performance loss.
@miloyip
Copy link
Collaborator Author

miloyip commented Jun 26, 2014

After experimenting (a1a8abd), the performance seems not an issue.
https://gist.github.com/miloyip/8120db4fdf702c6917d1

@miloyip miloyip mentioned this issue Jun 26, 2014
Merged
pah added a commit to pah/rapidjson-upstream that referenced this issue Jun 27, 2014
@pah
fix build on travis-ci.org
be01d3d 
Some early returns were missing after the removal of longjmp in Tencent#22.
This has led to segfaults on Linux (confirmed locally).
This was referenced Jun 27, 2014
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removal of setjmp()/longjmp() Tencent/rapidjson
1 participant
@miloyip