Fix segfault and build error on Linux #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some early returns were missing after the removal of longjmp in Tencent#22. This has led to segfaults on Linux (confirmed locally).
Another instance of casting away constness via C-style cast has been missed (introduced by Tencent#20).
miloyip
added a commit
that referenced
this pull request
Jun 27, 2014
Fix segfault and build error on Linux
|
Thanks. I was wondering how to inspect that crash, as I cannot reproduce it on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of setjmp/longjmp in #22 has introduced a segfault on Linux platforms, as shown on Travis CI.
These crashes have been caused by missing early returns after
ParseStringToStream. Additionally, an early return has been added after theParseArray/ParseObjectin the top-level code by jumping to the cleanup part directly.Last, but not least, constness has been casted away in my CopyFrom function (see #22).