Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize FindMember when use std::string #690

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Conversation

fuzhufang
Copy link
Contributor

if define RAPIDJSON_HAS_STDSTRING, FindMember use std::string, but it also use internal::StrLen to get the string lengtht,
when it call FindMember(StringRef(name)).
Now use GenericValue construct it, then can use the std::string.size.
now it will be faster.

also use internal::StrLen to get the string lengtht,
when it call FindMember(StringRef(name)).
Now use GenericValue construct it, then can use the std::string.size.
now it will be faster.
@coveralls
Copy link

coveralls commented Jul 21, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling b67ff2f on fuzhufang:master into 99ba17b on miloyip:master.

@miloyip
Copy link
Collaborator

miloyip commented Jul 21, 2016

Thanks

@miloyip miloyip merged commit 2f75165 into Tencent:master Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants