Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong length in remote schema #723

Merged
merged 1 commit into from
Sep 1, 2016
Merged

fix wrong length in remote schema #723

merged 1 commit into from
Sep 1, 2016

Conversation

niukuo
Copy link

@niukuo niukuo commented Aug 29, 2016

also hope to fix in v1.1.0

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 99.935% when pulling 8bcca03 on niukuo:master into 9bd618f on miloyip:master.

@coveralls
Copy link

coveralls commented Aug 31, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.937% when pulling f570409 on niukuo:master into 9bd618f on miloyip:master.

@niukuo
fix wrong length in remote schema
250cf66 
Change-Id: Ia96ddf5746f1c18968e9e086f17fe4a24b8480d7
@niukuo niukuo mentioned this pull request Aug 31, 2016
Closed
@coveralls
Copy link

coveralls commented Aug 31, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 99.937% when pulling 250cf66 on niukuo:master into 9bd618f on miloyip:master.

@miloyip miloyip merged commit cdb3454 into Tencent:master Sep 1, 2016
@miloyip
Copy link
Collaborator

miloyip commented Sep 1, 2016

Thank you

@miloyip
Copy link
Collaborator

miloyip commented Sep 1, 2016

Fixed #726

@niukuo
Copy link
Author

niukuo commented Sep 1, 2016

@miloyip will this fix release in v1.1.0?

@miloyip
Copy link
Collaborator

miloyip commented Sep 1, 2016

Cannot change existing release. Need to make a new minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niukuo @coveralls @miloyip