Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added assertion to help suppress clang warnings #757

Merged
merged 3 commits into from
Dec 23, 2016
Merged

added assertion to help suppress clang warnings #757

merged 3 commits into from
Dec 23, 2016

Commits on Sep 30, 2016

  1. added assertion to help suppress clang warnings

    @patcheng
    patcheng committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    9d8df28 View commit details
    Browse the repository at this point in the history

  2. Reserve() is sometimes called when stackTop_ is null. The assert is i… 

    …nvalid.
    @patcheng
    patcheng committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    91a803d View commit details
    Browse the repository at this point in the history

  3. When length is 0, the code does nothing, so skip it completely. 

    Previously, os.Push(0) would do nothing as well. But with the newly added assertion, is the stack is empty, it will fail the assertion.
    @patcheng
    patcheng committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    95224af View commit details
    Browse the repository at this point in the history