Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: input wrap class #276

Merged
merged 2 commits into from
Mar 8, 2022
Merged

refactor: input wrap class #276

merged 2 commits into from
Mar 8, 2022

Conversation

PengYYYYY
Copy link
Collaborator

@PengYYYYY PengYYYYY commented Mar 7, 2022

🤔 这个 PR 的性质是?

⚠️ 待react,vue2,vue3查验过后再合并

  • 日常 bug 修复

🔗 相关 Issue

💡 需求背景和解决方案

  1. 修复前后置标签输入框同事存在时左侧样式异常

image

  1. 调整 input输入框节点渲染,不再区分是否存在tips渲染t-input-wrap节点。同时为避免业务异常,外部传入class照常挂载在<div class=""t-input>节点。框架组件实现需要做逻辑处理

before

without tips
<div class="t-input"></div>

with tips

<div class="t-input-warp">
  <div class="t-input"></div>
  <div class="tips></div>
</div>

after

<div class="t-input-warp">
  <div class="t-input"></div>
</div>

📝 更新日志

  • fix(input): 修复前后置标签输入框同事存在时左侧样式异常

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

style/web/components

完成

@honkinglin
Copy link
Collaborator

React 验证没问题

@honkinglin honkinglin merged commit b348738 into develop Mar 8, 2022
@honkinglin honkinglin deleted the refactor/input/wrap branch March 8, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants