Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpaceProps property children should include array #1042

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

vikeychen
Copy link
Contributor

@vikeychen vikeychen commented Jul 5, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Space): 更改Space组件children属性为React.ReactNode

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

src/space/Space.tsx Outdated Show resolved Hide resolved
@honkinglin
Copy link
Collaborator

改成 React.ReactNode 支持的类型比较全,ReactElement 没有支持 null等奇怪的数据类型

@vikeychen
Copy link
Contributor Author

改好了,

@vikeychen vikeychen changed the title SpaceProps property children should be array SpaceProps property children should include array Jul 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1042 (b72c477) into develop (7b04365) will decrease coverage by 0.02%.
The diff coverage is 50.30%.

@@             Coverage Diff             @@
##           develop    #1042      +/-   ##
===========================================
- Coverage    60.40%   60.38%   -0.03%     
===========================================
  Files          937      951      +14     
  Lines        16498    16642     +144     
  Branches      3743     3802      +59     
===========================================
+ Hits          9966    10049      +83     
- Misses        6532     6593      +61     
Impacted Files Coverage Δ
src/_util/dom.ts 42.59% <ø> (ø)
src/_util/helper.ts 41.07% <ø> (ø)
src/_util/insertCSS.ts 0.00% <ø> (ø)
src/_util/number.ts 33.33% <ø> (ø)
src/_util/setStyle.ts 0.00% <ø> (ø)
src/_util/useDialogEsc.ts 46.66% <ø> (ø)
src/_util/useDragSorter.tsx 25.45% <ø> (ø)
src/_util/useRipple.ts 26.76% <ø> (ø)
src/anchor/Anchor.tsx 81.33% <ø> (ø)
src/anchor/_util/dom.ts 66.66% <ø> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5543c96...b72c477. Read the comment docs.

@honkinglin honkinglin merged commit ece7f77 into Tencent:develop Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

完成

@vikeychen vikeychen deleted the SpaceProps branch July 5, 2022 06:37
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants