Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 replace defaultProps with useDefaultProps #2397

Merged
merged 15 commits into from
Nov 28, 2023
Merged

fix: 🐛 replace defaultProps with useDefaultProps #2397

merged 15 commits into from
Nov 28, 2023

Conversation

li-jia-nan
Copy link
Contributor

@li-jia-nan li-jia-nan commented Jul 28, 2023 •
edited by uyarn
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Radio): 修复表单disabled未生效在Radio上的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023 •
edited
Loading

完成

@li-jia-nan li-jia-nan marked this pull request as draft July 28, 2023 03:27
@li-jia-nan li-jia-nan changed the title fix: 🐛 replace defaultProps with useDefaultProps fix: 🐛 [WIP] replace defaultProps with useDefaultProps Jul 28, 2023
@li-jia-nan li-jia-nan marked this pull request as ready for review October 10, 2023 11:39
@li-jia-nan li-jia-nan changed the title fix: 🐛 [WIP] replace defaultProps with useDefaultProps fix: 🐛 replace defaultProps with useDefaultProps Oct 10, 2023
@HaixingOoO
Copy link
Collaborator

@li-jia-nan 修改的文件相关form表单的禁用，需要更新一下snap再提交一下，运行

npm run test:snap-update

@li-jia-nan li-jia-nan closed this Nov 28, 2023
@li-jia-nan li-jia-nan reopened this Nov 28, 2023
@uyarn uyarn merged commit be13f67 into Tencent:develop Nov 28, 2023
9 checks passed
@li-jia-nan li-jia-nan deleted the Radio branch November 28, 2023 11:51
@github-actions github-actions bot mentioned this pull request Nov 30, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@li-jia-nan @HaixingOoO @uyarn