Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Empty): add empty component #2817

Merged
merged 24 commits into from
Aug 22, 2024
Merged

feat(Empty): add empty component #2817

merged 24 commits into from
Aug 22, 2024

Conversation

ZWkang
Copy link
Collaborator

@ZWkang ZWkang commented Mar 28, 2024 •
edited by uyarn
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

新增 Empty 组件

📝 更新日志

  • feat(Empty): 新增 Empty 空状态组件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

完成

@uyarn uyarn changed the title wip(empty): add empty component [WIP] feat(Empty): add empty component Mar 28, 2024
@uyarn uyarn added the WIP work in porgess label Mar 28, 2024
HaixingOoO
HaixingOoO reviewed Mar 28, 2024
View reviewed changes
src/empty/Empty.tsx Outdated Show resolved Hide resolved
NWYLZW
NWYLZW reviewed Jul 1, 2024
View reviewed changes
src/empty/Empty.tsx Outdated Show resolved Hide resolved
NWYLZW
NWYLZW reviewed Jul 1, 2024
View reviewed changes
src/empty/Empty.tsx Outdated Show resolved Hide resolved
@HaixingOoO HaixingOoO changed the title [WIP] feat(Empty): add empty component feat(Empty): add empty component Aug 11, 2024
@HaixingOoO
Copy link
Collaborator

/update-snapshot

@uyarn uyarn removed the WIP work in porgess label Aug 12, 2024
@uyarn
Copy link
Collaborator

uyarn commented Aug 12, 2024

路由上没有增加empty的路由 需要增加下

uyarn
uyarn reviewed Aug 12, 2024
View reviewed changes
src/empty/assets/EmptySvg.tsx Outdated Show resolved Hide resolved
src/empty/assets/SuccessSvg.tsx Show resolved Hide resolved
src/empty/assets/FailSvg.tsx Outdated Show resolved Hide resolved
uyarn
uyarn reviewed Aug 12, 2024
View reviewed changes
src/empty/Empty.tsx Outdated Show resolved Hide resolved
liweijie0812
liweijie0812 reviewed Aug 12, 2024
View reviewed changes
src/empty/Empty.tsx Outdated Show resolved Hide resolved
@HaixingOoO
Copy link
Collaborator

/update-snapshot

@liweijie0812
Copy link
Collaborator

API 补录：TDesignOteam/tdesign-api#366

@uyarn
Copy link
Collaborator

uyarn commented Aug 16, 2024 •
edited
Loading

WeChatWorkScreenshot_d3fc673b-3b58-44f6-9d53-dc1c309c76b3

设计 TODO

  • 大的好像大的不是很一致，最好可以统一尺寸 比如成功 失败 和其他状态就看起来差异很大
  • 是否可以定义一个中间尺寸的 现在应该是只有large和small
  • 大的和小的 图标不一致是否符合预期

@uyarn
Copy link
Collaborator

uyarn commented Aug 21, 2024

/update-snapshot

@uyarn uyarn merged commit 6549d65 into Tencent:develop Aug 22, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liweijie0812 liweijie0812 liweijie0812 left review comments

@NWYLZW NWYLZW NWYLZW left review comments

@HaixingOoO HaixingOoO HaixingOoO left review comments

@uyarn uyarn uyarn approved these changes

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZWkang @HaixingOoO @uyarn @liweijie0812 @NWYLZW