Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(tabs): reuse logic #521

Merged
merged 10 commits into from
Apr 1, 2022
Merged

Refactor(tabs): reuse logic #521

merged 10 commits into from
Apr 1, 2022

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented Mar 22, 2022 •
edited
Loading

🤔 这个 PR 的性质是？

  • 新特性提交
  • 重构

🔗 相关 Issue

无

💡 需求背景和解决方案

复用代码，补齐特性

📝 更新日志

  • feat(tabs): 优化滚动方式，与 Vue 保持一致，使用 transform 实现
  • feat(tabs): 支持当 value 的值变化时，自动滚动至该 tab
  • feat(tabs): 支持 window.resize 之后，实时计算是否出现左右箭头

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@LeeJim LeeJim changed the title [WIP] Refactor(Tabs): reuse code [WIP] Refactor(Tabs): reuse logic Mar 22, 2022
@LeeJim LeeJim changed the title [WIP] Refactor(Tabs): reuse logic Refactor(Tabs): reuse logic Mar 22, 2022
@LeeJim LeeJim mentioned this pull request Mar 22, 2022
Merged
6 tasks
@LeeJim LeeJim changed the title Refactor(Tabs): reuse logic Refactor(tabs): reuse logic Mar 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2022 •
edited
Loading

完成

@honkinglin honkinglin merged commit ec7877d into Tencent:develop Apr 1, 2022
uyarn pushed a commit that referenced this pull request Apr 18, 2022
@honkinglin
Merge pull request #521 from LeeJim/refactor/tabs
a0989e4 
Refactor(tabs): reuse logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honkinglin honkinglin honkinglin approved these changes

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeeJim @honkinglin