Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/image viewer #954

Merged
merged 43 commits into from
Aug 5, 2022
Merged

Conversation

Ylushen
Copy link
Contributor

@Ylushen Ylushen commented Jun 24, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#714

💡 需求背景和解决方案

📝 更新日志

  • feat(ImageViewer): 新增ImageViewer组件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022

完成

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #954 (f7c4aea) into develop (ca9bc02) will decrease coverage by 0.40%.
The diff coverage is 40.83%.

@@             Coverage Diff             @@
##           develop     #954      +/-   ##
===========================================
- Coverage    60.29%   59.89%   -0.41%     
===========================================
  Files          969      992      +23     
  Lines        17151    17511     +360     
  Branches      3945     4009      +64     
===========================================
+ Hits         10342    10489     +147     
- Misses        6809     7022     +213     
Impacted Files Coverage Δ
src/image-viewer/hooks/usePosition.ts 2.63% <2.63%> (ø)
src/image-viewer/utils.ts 5.26% <5.26%> (ø)
src/image-viewer/hooks/useScale.ts 6.25% <6.25%> (ø)
src/image-viewer/ImageViewerModel.tsx 6.42% <6.42%> (ø)
src/image-viewer/hooks/useIndex.ts 10.00% <10.00%> (ø)
src/image-viewer/hooks/useMirror.ts 16.66% <16.66%> (ø)
src/image-viewer/hooks/useRotate.ts 16.66% <16.66%> (ø)
src/image-viewer/ImageViewerMini.tsx 25.00% <25.00%> (ø)
src/image-viewer/hooks/useIconMap.ts 33.33% <33.33%> (ø)
src/image-viewer/ImageViewer.tsx 68.18% <68.18%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

site/site.config.mjs Outdated Show resolved Hide resolved
@eugenewoody
Copy link

eugenewoody commented Jul 18, 2022

【imageviewer 图片】走查
网址:https://preview-pr954-tdesign-react.surge.sh/react/components/image-viewer
具体修改细节如下(详见图片):
vi
-缩略图片查看器-

  1. 需使用视觉侧提供的图片(视觉侧负责提供)
    2.操作栏的【查看原图】icon样式不对
    3.操作栏缺少【下载】按钮
    4.操作栏中,icon大小不一致
    5.缩略图样式不对,缺少外框
    -文字查看器-
    6.操作栏缺少hover态
    7.操作栏的padding和margin的数值不对
    8.关闭按钮的颜色及样式不对
    -多张图预览查看器-
    9.图片列表展开的选中样式不对
    10.图片列表展开的hover样式不对
    -相册预览-
    11.相册封面的遮罩样式不对
    12.当前页数的样式不对
    13.关闭按钮的位置不对
    14.图片的跳转方式为,选中的图片自动滑动居中
    15.【上/下一页】缺少最后一页样式【设计侧补充样式】
    16.打开图片不需要嵌套入卡片
    -渐进加载预览-
    17.加载样式与设计稿(加载中模糊,加载完成图片可清晰浏览)不符。
    -加载失败的图片-
    18.加载失败样式不对,含icon和背景色
    -从操作栏触发的图片查看器-
    19.【更多】操作的组件dropdown的padding应为6
    20.封面遮罩上的边距和间距不对
    21.图片列表展开时,当前页被遮挡
    -其他-
    22.图片缩略图缺少【hover】态
    23.小窗模式圆角@radius-medium:6px

site/site.config.mjs Outdated Show resolved Hide resolved
src/image-viewer/useHooks.ts Outdated Show resolved Hide resolved
@Ylushen
Copy link
Contributor Author

Ylushen commented Jul 20, 2022

【imageviewer图片】走查修复
2. 下载图标仅在支持下载的图片才会展示
3. 滚动条的效果在这是否不需要,一般预览图片应该不会过多
17. 渐进加载,默认优先展示了小图,可能因为图片缓存原因,导致切换过快。实际是有的。
18. 加载失败的icon需要加上,样式已加待替换
19. 使用tdesign通用的select组件样式。
23. tdesign通用的dialog弹窗样式

@eugenewoody
Copy link

eugenewoody commented Aug 1, 2022

视觉走查问题更新 light-mode dark mode

  • light mode-
    第2、3、6、8、9、10、14中需要修改。(备注:建议14中打开图片动效的路径由小图位置过渡到屏幕中央)
    补充
    补充问题
    -dark mode-
    第6的尺寸不对
    补充
    缩略图的大小(含边框)是168,不是167.99
    图片加载失败缺少边框

截屏2022-08-01 下午3 32 47

src/image-viewer/ImageViewerMini.tsx Outdated Show resolved Hide resolved
src/image-viewer/_example/albumIcons.jsx Outdated Show resolved Hide resolved
src/image-viewer/_example/albumIcons.jsx Outdated Show resolved Hide resolved
src/image-viewer/_example/base.jsx Outdated Show resolved Hide resolved
src/image-viewer/_example/block.jsx Outdated Show resolved Hide resolved
src/image-viewer/_example/error.jsx Outdated Show resolved Hide resolved
src/image-viewer/_example/multiple.jsx Outdated Show resolved Hide resolved
src/image-viewer/hooks/useIndex.ts Outdated Show resolved Hide resolved
src/image-viewer/hooks/useList.ts Outdated Show resolved Hide resolved
src/image-viewer/hooks/useViewerScale.ts Outdated Show resolved Hide resolved
@Ylushen Ylushen changed the title (WIP)Feature/image viewer Feature/image viewer Aug 4, 2022
src/image-viewer/utils.ts Outdated Show resolved Hide resolved
@honkinglin honkinglin merged commit a25110b into Tencent:develop Aug 5, 2022
@Ylushen Ylushen deleted the feature/image-viewer branch August 5, 2022 01:49
@honkinglin honkinglin linked an issue Aug 8, 2022 that may be closed by this pull request
@honkinglin honkinglin mentioned this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ImageViewer] 新增 ImageViewer 组件
7 participants