Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: form whitespace #1095

Merged
merged 2 commits into from
Jun 30, 2022
Merged

feat: form whitespace #1095

merged 2 commits into from
Jun 30, 2022

Conversation

PengYYYYY
Copy link
Collaborator

@PengYYYYY PengYYYYY commented Jun 30, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Form): 添加内置校验方法 whitespace
  • fix(Dialog): 修复 closeOnOverlayClick closeOnEscKeydown 默认值导致的无法设置的问题 (#1096 )
  • fix(Drawer): 修复 closeOnOverlayClick closeOnEscKeydown 默认值导致的无法设置的问题 (#1097 )
  • fix(Drawer): 修复 header 默认值为 undefined

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

完成

@codecov-commenter
Copy link

Codecov Report

Merging #1095 (1dda212) into develop (a0db0df) will increase coverage by 1.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1095      +/-   ##
===========================================
+ Coverage    57.56%   59.45%   +1.89%     
===========================================
  Files          346      406      +60     
  Lines        12828    15054    +2226     
  Branches      2405     2820     +415     
===========================================
+ Hits          7384     8951    +1567     
- Misses        5200     5832     +632     
- Partials       244      271      +27     
Impacted Files Coverage Δ
src/swiper/props.ts 68.75% <0.00%> (-31.25%) ⬇️
src/dialog/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/calendar/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/date-picker/props.ts 70.00% <0.00%> (-30.00%) ⬇️
src/drawer/props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/pagination/props.ts 72.72% <0.00%> (-27.28%) ⬇️
src/affix/affix.tsx 39.06% <0.00%> (-27.01%) ⬇️
src/popup/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/select/props.ts 75.00% <0.00%> (-25.00%) ⬇️
src/slider/props.ts 75.00% <0.00%> (-25.00%) ⬇️
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514bb29...1dda212. Read the comment docs.

@honkinglin honkinglin merged commit b755312 into develop Jun 30, 2022
@honkinglin honkinglin deleted the feat/form/whitespace branch June 30, 2022 04:37
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants