Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Footer Merge Cells Support; <col min-width> support #1217

Merged
merged 7 commits into from
Jul 28, 2022

Conversation

chaishi
Copy link
Collaborator

@chaishi chaishi commented Jul 26, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Table): 支持使用插槽 footer-summary 定义通栏表尾,同时支持同名属性 Props footer-summary 渲染通栏表尾
  • feat(Table): 由于表格支持定义多行表尾,因而本次支持使用 rowspanAndColspanInFooter 定义表尾行数据合并单元格,使用方法同 rowspanAndColspantdesign-vue-next#issue1047
  • feat(Table): 支持 min-width 透传到元素 <col>issues#708
2022-07-28.17.40.18.mov
  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@chaishi chaishi changed the title [Table] Footer Merge Cells Support [Table] Footer Merge Cells Support; <col min-width> support Jul 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

完成

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature@a1e37bd). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             feature    #1217   +/-   ##
==========================================
  Coverage           ?   58.53%           
==========================================
  Files              ?      406           
  Lines              ?    15179           
  Branches           ?     2878           
==========================================
  Hits               ?     8885           
  Misses             ?     6019           
  Partials           ?      275           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e37bd...544ee5d. Read the comment docs.

@uyarn uyarn merged commit eeb19f7 into Tencent:feature Jul 28, 2022
@uyarn uyarn self-requested a review July 28, 2022 11:31
@xiaosansiji xiaosansiji mentioned this pull request Aug 2, 2022
chaishi added a commit that referenced this pull request Aug 2, 2022
* feat(table): footer-summary slot support for full footer row

* feat(table): footer merge cells support

* fix(table): do not render tfoot withour neither of footData and footerSummary

* feat(table): min-width of col support

* feat(table): add footerSummary to props

* test(table): update snapshots

* fix(table): log error
chaishi added a commit that referenced this pull request Aug 2, 2022
…ort (#1217)

* feat(table): footer-summary slot support for full footer row

* feat(table): footer merge cells support

* fix(table): do not render tfoot withour neither of footData and footerSummary

* feat(table): min-width of col support

* feat(table): add footerSummary to props

* test(table): update snapshots

* fix(table): log error
xiaosansiji pushed a commit that referenced this pull request Aug 2, 2022
…ort (#1217) (#1238)

* feat(table): footer-summary slot support for full footer row

* feat(table): footer merge cells support

* fix(table): do not render tfoot withour neither of footData and footerSummary

* feat(table): min-width of col support

* feat(table): add footerSummary to props

* test(table): update snapshots

* fix(table): log error
@github-actions github-actions bot mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants