Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(新增image-viewer): 新增image-viewer #1520

Merged
merged 5 commits into from
Sep 26, 2022

Conversation

sinbadmaster
Copy link
Contributor

@sinbadmaster sinbadmaster commented Sep 16, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Tencent/tdesign#227

💡 需求背景和解决方案

📝 更新日志

  • feat(ImageViewer): 新增 image-viewer 组件

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022

完成

@PengYYYYY
Copy link
Collaborator

PengYYYYY commented Sep 24, 2022

Screen.Recording.2022-09-24.at.22.04.20.mov

有点样式上的问题,vue3同样有

@codecov-commenter
Copy link

Codecov Report

Merging #1520 (084fefb) into develop (492d477) will increase coverage by 3.50%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1520      +/-   ##
===========================================
+ Coverage    57.94%   61.44%   +3.50%     
===========================================
  Files          407      675     +268     
  Lines        15371    16222     +851     
  Branches      2931     2863      -68     
===========================================
+ Hits          8907     9968    +1061     
+ Misses        6187     5963     -224     
- Partials       277      291      +14     
Impacted Files Coverage Δ
src/range-input/range-input-popup-props.ts 25.00% <0.00%> (-75.00%) ⬇️
src/grid/row-props.ts 71.42% <0.00%> (-28.58%) ⬇️
src/select/util.ts 65.00% <0.00%> (-26.67%) ⬇️
src/select/props.ts 54.54% <0.00%> (-20.46%) ⬇️
src/affix/affix.tsx 22.72% <0.00%> (-16.34%) ⬇️
src/date-picker/props.ts 53.84% <0.00%> (-16.16%) ⬇️
src/date-picker/date-range-picker-props.ts 42.85% <0.00%> (-11.69%) ⬇️
src/select/optionGroup.tsx 31.57% <0.00%> (-9.60%) ⬇️
src/cascader/props.ts 55.55% <0.00%> (-8.74%) ⬇️
src/upload/dragger.tsx 27.27% <0.00%> (-7.51%) ⬇️
... and 463 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PengYYYYY PengYYYYY merged commit 26220bb into Tencent:develop Sep 26, 2022
@github-actions github-actions bot mentioned this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants