Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): fix options method #3155

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

Summer-Shen
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Tencent/tdesign-react#2852

💡 需求背景和解决方案

📝 更新日志

  • fix(upload): fix options method

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Apr 25, 2024

完成

@uyarn
Copy link
Collaborator

uyarn commented Apr 27, 2024

sorry 昨天没看到PR 发布版本的时候更新了common 需要再处理下冲突了

@Summer-Shen
Copy link
Contributor Author

Summer-Shen commented Apr 27, 2024

sorry 昨天没看到PR 发布版本的时候更新了common 需要再处理下冲突了

我刚刚好像把 common 回退到上个 commit 了,可能还是应该 develop 更新到 common 最新的 commit?

@uyarn
Copy link
Collaborator

uyarn commented Apr 27, 2024

sorry 昨天没看到PR 发布版本的时候更新了common 需要再处理下冲突了

我刚刚好像把 common 回退到上个 commit 了,可能还是应该 develop 更新到 common 最新的 commit?

我直接在你的PR上改

@uyarn
Copy link
Collaborator

uyarn commented Apr 27, 2024

sorry 昨天没看到PR 发布版本的时候更新了common 需要再处理下冲突了

我刚刚好像把 common 回退到上个 commit 了,可能还是应该 develop 更新到 common 最新的 commit?

因为我们在拉分支之后都更新了common 后来我的改动先合入了主干 所以你需要rebase主干(处理冲突)之后,确保common带上了option的改动就可以

@uyarn uyarn merged commit 21c5927 into Tencent:develop Apr 27, 2024
5 checks passed
@Summer-Shen Summer-Shen deleted the fix/upload-method-options branch April 27, 2024 10:16
@github-actions github-actions bot mentioned this pull request May 16, 2024
16 tasks
uyarn added a commit that referenced this pull request May 16, 2024
* chore: update common

* fix(upload): fix options method

* chore: update common

---------

Co-authored-by: Uyarn <uyarnchen@gmail.com>
uyarn added a commit that referenced this pull request May 16, 2024
* fix(upload): fix options method (#3155)

* chore: update common

* fix(upload): fix options method

* chore: update common

---------

Co-authored-by: Uyarn <uyarnchen@gmail.com>

* chore: fix docs (#3161)

* chore: fix docs

* chore: fix lint

* fix(color-picker): 修复切换预览颜色时,通道按钮位置不变的问题 (#3163)

* feat(input): add borderless mode (#3162)

* feat: add label prop API for date pickers and range input (#3169)

---------

Signed-off-by: Siubeng <fython@163.com>
Co-authored-by: Uyarn <uyarnchen@gmail.com>

* fix(range-input): 修复 prefix/suffix 内容未应用居中样式的问题 (#3175)

* fix(range-input): add missing classes to fix unexpected align of prefix/suffix in component

* test(range-input): update snapshots for range-input and related components

* fix(select): fix default value missing (#3177)

* fix(select): fix default value missing

* chore: update snapshot

* chore: update common to synchronize style and docs fix (#3178)

* chore: release 1.9.4-naruto

---------

Signed-off-by: Siubeng <fython@163.com>
Co-authored-by: Yunfei Shen <shenyf0608@163.com>
Co-authored-by: fennghuang <89014758+fennghuang@users.noreply.github.com>
Co-authored-by: Siubeng <fython@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants