Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range-input): 修复 prefix/suffix 内容未应用居中样式的问题 #3175

Merged
merged 2 commits into from
May 16, 2024

Conversation

fython
Copy link
Contributor

@fython fython commented May 15, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

需求背景参考 Issue 原文。排查过程定位到原 tdesign-common 项目中样式已包含以下定义,无需额外添加样式:

.range-input-fix-position(@position) {
  &.@{prefix}-range-input--@{position} {
    .@{prefix}-range-input__@{position} {
      height: 100%;
      text-align: center;
      display: flex;
      align-items: center;
      font-size: @font-size-base;
    }
  }
}

在保持原样式不动基础上,为 RangeInput 组件的渲染函数补充 ${COMPONENT_NAME}--prefix${COMPONENT_NAME}--suffix 的 class 动态赋值判断,以复用上述样式。此部分实现对齐 Input 实现。

📝 更新日志

  • fix(RangeInput): 修复 prefix/suffix 未垂直居中对齐的问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented May 15, 2024

完成

@uyarn uyarn merged commit 96d023c into Tencent:develop May 16, 2024
6 checks passed
@fython fython deleted the fix/range-input-suffix-align branch May 16, 2024 08:41
@github-actions github-actions bot mentioned this pull request May 16, 2024
16 tasks
uyarn pushed a commit that referenced this pull request May 16, 2024
* fix(range-input): add missing classes to fix unexpected align of prefix/suffix in component

* test(range-input): update snapshots for range-input and related components
uyarn added a commit that referenced this pull request May 16, 2024
* fix(upload): fix options method (#3155)

* chore: update common

* fix(upload): fix options method

* chore: update common

---------

Co-authored-by: Uyarn <uyarnchen@gmail.com>

* chore: fix docs (#3161)

* chore: fix docs

* chore: fix lint

* fix(color-picker): 修复切换预览颜色时,通道按钮位置不变的问题 (#3163)

* feat(input): add borderless mode (#3162)

* feat: add label prop API for date pickers and range input (#3169)

---------

Signed-off-by: Siubeng <fython@163.com>
Co-authored-by: Uyarn <uyarnchen@gmail.com>

* fix(range-input): 修复 prefix/suffix 内容未应用居中样式的问题 (#3175)

* fix(range-input): add missing classes to fix unexpected align of prefix/suffix in component

* test(range-input): update snapshots for range-input and related components

* fix(select): fix default value missing (#3177)

* fix(select): fix default value missing

* chore: update snapshot

* chore: update common to synchronize style and docs fix (#3178)

* chore: release 1.9.4-naruto

---------

Signed-off-by: Siubeng <fython@163.com>
Co-authored-by: Yunfei Shen <shenyf0608@163.com>
Co-authored-by: fennghuang <89014758+fennghuang@users.noreply.github.com>
Co-authored-by: Siubeng <fython@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants