Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove parent pom depdendencies, which break maven consumers #7

Merged
merged 1 commit into from
Oct 17, 2017
Merged

chore: remove parent pom depdendencies, which break maven consumers #7

merged 1 commit into from
Oct 17, 2017

Conversation

JohannesRudolph
Copy link

The way Physikal is currently packaged on maven central, the pom e.g. of si-units-1.1.1.0 currently includes:

    <dependency>
      <groupId>si.uom</groupId>
      <artifactId>si-parent</artifactId>
      <version>0.7.1</version>
      <scope>compile</scope>
    </dependency>

This breaks consumers of Physikal using maven to build:

[ERROR] Failed to execute goal on project model-nosql: Could not resolve dependencies for project de.xxx.core:model-nosql:jar:0.9: The following artifacts could not be resolved: systems.uom:systems-parent:jar:0.7.2, si.uom:si-parent:jar:0.7.1: Failure to find systems.uom:systems-parent:jar:0.7.2 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]

I think the situation si somewhat similar to https://stackoverflow.com/questions/27110014/could-not-find-artifact-in-maven-central-repo-when-search-returns-a-match

In any case, I believe the parent pom is not necessary as a direct dependency. I confirm I can build and consume phyiskal to my local repo just fine using the change in this PR.

@ejberry ejberry self-assigned this Oct 17, 2017
@ejberry ejberry merged commit 860f8d3 into Tenkiv:master Oct 17, 2017
@ejberry
Copy link
Member

ejberry commented Oct 17, 2017

Accepted, thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants