Add clj-kondo support for cljd.flutter.alpha/widget

[D00mch]

I decided to use /hooks as a directory inside clj-kondo.exports/<your-org>/<your-libname>/
somewhat like sicmutils does.

Why is .git ignore changed?

Without it there would be generated files:

It doesn't depend on my implementation, I checked better-cond, there is the same problem after opening it's files with lsp running:

Where does it started?

https://clojurians.slack.com/archives/C03A6GE8D32/p1650354879575349

Links to check

• clj-kondo export docs
• another examples

[D00mch]

todo: also support :key, :watch and :context done

[D00mch]

Still working on it... done

[cgrand]

body length can be anything, even if it will be most of the time 1, it may be more in case of side-effects, a length of 0 would be most certainly an error.

[D00mch]

I guess, something like this will do the job:

:else 
        {:node (api/list-node 
                 (list
                   (api/token-node 'let)
                   (api/vector-node (:children state))
                   watch
                   key
                   body))}

It generates something like (let [state-name state-value] watch-value, key-value, body)

Only context allow to generate new symbols

[D00mch]

[D00mch]

I will see what else could be done, today evening

[cgrand]

I don't understand what's this function must return. There seems to be keywords in binding position in the generated let.

[D00mch]

Now it returns something like:

(let [context-name-user-provided identity ; if user privides context
      state-name state-value ; if user provides a state 
      ]

    ;; need it to check if these symbols exist 
    watch ; could be nil
    key ; could be nil 

    (widget. (body. (creation. )))

[cgrand]

If you could add the symbol check on state name, merge all state checks in one single branch that would be perfect and I would merge.
I also provided variants to your messages.

Thanks!

[cgrand]

could raise some false positive but it's so unlikely and useless that's ok

[D00mch]

What examples do you think may become a false positive?
Only when there is a key-word pair, it raises an exception

[cgrand]

I believe these two branches should be merged and the error message should read ":state should be a vector [name initial-value]". Btw you should also check in that branch that name is a simple symbol.

[D00mch]

Ok, I will merge them.

As for symbol name — it's already checked by the let form:

[cgrand]

"Unsupported option keys: "

[D00mch]

It would look like

So may be remove ':' after keys? Or its fine?

[cgrand]

":state and :watch option keys are mutually exclusive."

[cgrand]

But doesn’t the let allow for destructuring  too?   Christophe Grand Le 21 avr. 2022 à 09:28, Artur Dumchev ***@***.***> a écrit :  @Liverm0r commented on this pull request.

-------------------------------- In resources/clj-kondo.exports/tensegritics/clojuredart/hooks/flutter.clj <#29 (comment)> :

+ (and state (not (api/vector-node? state)))

+ (error "State should be a vector [name initial-value]") + + (and state (not= (count (:children state)) 2)) + (error "State should contain only one name-value pair") Ok, I will merge them. As for symbol name — it's already checked by the let form: — Reply to this email directly, view it on GitHub <#29 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALPMKVFIJTE3DBCQT5KVTVGD7QZANCNFSM5TZTSSYQ> . You are receiving this because your review was requested. <https://github.com/notifications/beacon/AAALPMMRD6HDHD5P243FR2LVGD7QZA5CNFSM5TZTSSY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHCB7QYQ.gif> Message ID: ***@***.***>

[D00mch]

I see, didn't think about destructuring. I will fix it too.