Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hero-banner): add support for hero banner and typography #11

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Jun 12, 2024

Description

Add support for hero banner in banner component.
Add a typography component.

What's included?

  • Typogrpahy component for headlines, body and captions.
  • Add a isHero prop to banner to convert it into a hero banner.

Test Steps

  • nx run react-components:storybook
  • Navigate to Banner -> Hero
  • Navigate to Typogrpahy -> Basic

General Tests for Every PR

  • npm run start still works.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-06-12 at 4 39 07 PM

Hero Banner

Screenshot 2024-06-12 at 4 41 24 PM

@owilliams320 owilliams320 merged commit 31f1852 into main Jun 13, 2024
7 checks passed
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants