chore: add display name to chest prefab #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
added
Category: Gameplay Content
skaldarnar
force-pushed
the
feat/add-chest-displayname
branch
from
515c865
to
8c08567
Compare
skaldarnar
approved these changes
Aug 6, 2021
| @@ -1,4 +1,7 @@ | |||
| { | |||
| "DisplayName": { | |||
| "name": "Chest" | |||
There was a problem hiding this comment.
Can we make this translatable?
skaldarnar
reviewed
Aug 6, 2021
| @@ -1,4 +1,7 @@ | |||
| { | |||
| "DisplayName": { | |||
| "name": "${coreadvancedassets:game#furnishings-chest}" | |||
There was a problem hiding this comment.
One drawback of this approach is that if a screen just renders this value as a text without an explicit call to TranslationSystem#translate(...) this unreadable string will show up...
I don't understand (yet) why using this reference string in a .ui file directly is automatically translated, but we return this string in a programmatic binding it is not. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustment to add a display name for chests.
Especially the feature added in Terasology/Inventory#45 will benefit of this.