Code quality tweaks #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntaxi
reviewed
Jun 19, 2019
|
|
||
| public long getLowestEndTime() { | ||
| return lowestEndTime; | ||
| return soonestEndTime; |
There was a problem hiding this comment.
You need to do something with result here
| private float remainder; | ||
| public long soonestEndTime; | ||
| public Map<String, Float> regenValue = new HashMap<>(); | ||
| public Map<String, Long> regenEndTime = new HashMap<>(); |
There was a problem hiding this comment.
If you can find a way, make this a map sorted on the long value. It will greatly improve performance because at present to find min, & to remove below a specific amount then you can quickly and easily do this. It does make removing by id harder, but this is not as often needed.
|
Closing as superseded by #16, which is now merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove logs and unused events.
Update tests for regeneration