Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For solving the multi block non healing bug #16

Merged
merged 9 commits into from Jun 21, 2019

Conversation

e-aakash
Copy link
Member

@e-aakash e-aakash commented Jun 20, 2019

#12 rebased on master.
Added some loggers for finding whats going wrong

How to test:

  1. Start a game with BSG and Health module.
  2. Hit many blocks consecutively.
  3. See that all of them regenerate, and not any gets "stuck" in damaged state.

@e-aakash e-aakash marked this pull request as ready for review June 20, 2019 17:55
@Cervator
Copy link
Member

Tests out! Ran all the unit tests, tried BSG in both single player and multiplayer, everything seems to be working. Nicely done :-)

One observation, which I actually favor, at least personally: regeneration seems a little erratic in timing, which I think adds a bit of spice instead of mechanical on-the-dot accuracy. Can see if you damage a large area of blocks in a row or if you heavily damage a player then wait and time how fast each half-heart returns.

@Cervator Cervator merged commit bd9c055 into Terasology:master Jun 21, 2019
@Cervator Cervator mentioned this pull request Jun 21, 2019
@e-aakash e-aakash deleted the regen2 branch June 22, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants