Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge packages #209

Closed
wants to merge 2 commits into from
Closed

Conversation

ahv15
Copy link
Member

@ahv15 ahv15 commented Jun 10, 2021

Merged las and ligthandshadow into a single package based on the below structure.
image
New Structure
image

@jdrueckert
Copy link
Member

A few questions/remarks:

  1. What do SetTeamAction and ScoreHud have to do with world gen?
  2. In comparison to barrier and flag, jobs and logic seem a bit generic
  3. What do ClientSkin, Teleporter and particles have to do with the gamestate?
  4. While PlayerDeath might result from combat, I'm not sure, it's a very good fit for a combat pkg. Same for PlayerStatistics which admittedly do consist mostly of K/D but also of captured flags / scored points.

To be honest this feels a bit as if you just copied the contents of one of the two packages into the other without really putting much thought into a suitable structure. Don't get me wrong, splitting up the former componentsystem sub-package is a good start, but this definitely does not cover it.

We expect a consistent and meaningful structure on which we can build for the rest of the module overhaul. Naturally, over the course of the overhaul it's possible that there will be some more adjustments to it, but we need a reasonable base to work with.

@jdrueckert
Copy link
Member

Superseded by #245

@jdrueckert jdrueckert closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants