refactor: merge las and ligthandshadow pkgs into lightandshadow pkg #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrueckert
added
Topic: Stabilization
skaldarnar
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
I don't see any blocker for this. Light and Shadow is a top-level gameplay module that is not used by other modules affected by this package restructuring 👍
Also big thanks to @ahv15 for the first attempt!
jdrueckert
added a commit
that referenced
this pull request
Nov 12, 2021
…245) This does a rather coarse grained re-ordering of the files and simply aims to merge the two legacy packages by moving the files into the following structure: ``` org.terasology.module |_ lightandshadow| |_ components |_ components |_ components ``` components events systems ui world
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is superseding #209 which has gone out of sync due to the gestalt component migration. It does a less fine-granular re-ordering of the files and simply aims to merge the two legacy packages by moving the files into the following structure:
In the context of the state-machine-based rework of this module, the structure is bound to change, so I don't think it makes too much sense to invest a lot of time into a fine-grained file structure yet.
Supersedes #209